Repository navigation
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptile-apps please re-review. Addressed the open P1/P2 items in the latest push on this branch. |
AatmanAJ
force-pushed
the
perf/win-fragmented-gpu-encode
branch
from
October 30, 2026 00:26
4e93812 to
e077503
Compare
Contributor
Author
|
@greptile-apps review |
2 similar comments
Contributor
Author
|
@greptile-apps review |
Contributor
Author
|
@greptile-apps review |
Member
|
Thanks! Can you rebase on main to clear the conflicts and resolve the open review threads? Then we'll take a look. |
…cale Rebased onto main. The split readback/encode thread now reports encode failures through report_encode_result and handles main's mid-recording hardware-to-software encoder fallback: queue_preconverted_frame recovers like queue_frame, and the converter pool is rebuilt when the fallback encoder needs a different input format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AatmanAJ
force-pushed
the
perf/win-fragmented-gpu-encode
branch
from
November 4, 2026 17:58
ea8bf7c to
9633795
Compare
Contributor
Author
|
@greptile-apps review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefer_external_conversionand feed frames throughAsyncConverterPool(D3D11 video processor when available) withqueue_preconverted_frame_to, overlapping GPU/CPU conversion with readback and libx264/NVENC work.VideoInfomatches the encode resolution instead of capturing native 4K and scaling twice (capture scaler + encoder swscale).VideoProcessorBltfor dimension mismatches and read back only at the target resolution; fall back to the existing CPU swscale path when the GPU scaler cannot be created.Not in this PR (follow-up)
WindowsMuxerinto fragmented M4S (zero-copy texture encode for studio/instant segments).Test plan
cargo check -p cap-recording(CI).

Confidence Score: 5/5
The PR appears safe to merge based on the reviewed code.Summary
This PR overlaps Windows frame readback, conversion, and H.264 encoding.
No new actionable issues were established. All six previous, unnumbered findings are addressed in the current code: module placement, the unsafe call, frame ordering, colors, failed-setup caching, and sequence advancement.
Checks were limited to source review; no build or runtime tests were run.
Reviews (6) · Last reviewed commit: "perf(recording): overlap Windows fragmen..." · Reviewed by Greptile